Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change heading on foreign-travel-advice #2386

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

chris-gds
Copy link

@chris-gds chris-gds commented Mar 9, 2022

What

Change to component, alter from h1 to h2 on page: https://www.gov.uk/foreign-travel-advice/afghanistan

Why

The problem is that in part-separated content we have two h1 headings, one for the guide name, then one for the part name, and then the content is displayed with h2 headings. Make the guide heading a h2 even though it comes before the part heading. This is not ideal as it's a slightly confusing structure but does not violate any standards and it leaves the h1 as the most relevant title on the page.

Visual changes

None

Anything else

Ideally the Content under the h2 should now be updated to h3 however this lives within govspeak controlled by Content teams. Been made aware there are 226 different guides to update.
https://www.gov.uk/foreign-travel-advice/afghanistan

Change to component, alter from h1 to h2 on page: https://www.gov.uk/foreign-travel-advice/afghanistan
@govuk-ci govuk-ci temporarily deployed to government-f-update-hea-9f51um March 9, 2022 12:54 Inactive
@chris-gds chris-gds marked this pull request as ready for review March 10, 2022 10:07
@chris-gds chris-gds marked this pull request as draft March 10, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants